From: vanadiae Date: Tue, 20 Jul 2021 12:11:28 +0000 (+0200) Subject: popupMenu: Remove can_focus=True from Switch X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~574^2^2~184 X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=7dd7714fd24baab3fb51ecbebcfaba31c325dc5e;p=gnome-shell.git popupMenu: Remove can_focus=True from Switch Since this is a bin and not a button, and it doesn't have any click/keyboard handling on its own (as in that case it needs a parent button wired like in the messages list controls), it is confusing that it has can_focus set to True. To avoid any confusion, this commit removes it without breaking anything since it had no real use. Part-of: --- diff --git a/js/ui/popupMenu.js b/js/ui/popupMenu.js index 11528560d..ff83d2ceb 100644 --- a/js/ui/popupMenu.js +++ b/js/ui/popupMenu.js @@ -324,7 +324,6 @@ var Switch = GObject.registerClass({ super._init({ style_class: 'toggle-switch', accessible_role: Atk.Role.CHECK_BOX, - can_focus: true, state, }); }